[webkit-reviews] review granted: [Bug 227687] [GStreamer] Looped video is not seamless (flicker inbetween loops) : [Attachment 433790] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 227687: [GStreamer] Looped video is not seamless (flicker inbetween loops)
https://bugs.webkit.org/show_bug.cgi?id=227687

Attachment 433790: Patch

https://bugs.webkit.org/attachment.cgi?id=433790&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 433790
  --> https://bugs.webkit.org/attachment.cgi?id=433790
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433790&action=review

> Source/WebCore/ChangeLog:10
> +	   non-flushing seeks to seek back to the beginning of the media. This
ensure a seamless
> +	   behavior has the pipeline state doesn't change and sinks don't
flush. This can be done only

This ensure...don't flush does not "parse".

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:471
> +

Extra line