[webkit-reviews] review granted: [Bug 228092] [JSC] StructureStubInfo's m_identifier should follow to the same protocol of inlineAccessBaseStructure : [Attachment 433831] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 228092: [JSC] StructureStubInfo's m_identifier should follow to the same
protocol of inlineAccessBaseStructure
https://bugs.webkit.org/show_bug.cgi?id=228092

Attachment 433831: Patch

https://bugs.webkit.org/attachment.cgi?id=433831&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 433831
  --> https://bugs.webkit.org/attachment.cgi?id=433831
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433831&action=review

r=me

> Source/JavaScriptCore/ChangeLog:10
> +	   m_identifier field too. This patch makes m_identifier follow to the
same protocol of inlineAccessBaseStructure
> +	   so that we fix this race issue too.

I'd document just for completeness what we're doing specifically (so folks
don't have to read r279813 change)

> Source/JavaScriptCore/bytecode/StructureStubInfo.cpp:-422
> -void StructureStubInfo::setCacheType(const ConcurrentJSLockerBase&,
CacheType newCacheType)

I would keep this function. It's nice to document/enforce that we're holding
the lock. See https://trac.webkit.org/changeset/264388/webkit