[webkit-reviews] review granted: [Bug 228086] [iOS] Tapping images on twitter.com should not toggle tab bar visibility : [Attachment 433824] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 19 15:09:56 PDT 2021


Geoffrey Garen <ggaren at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 228086: [iOS] Tapping images on twitter.com should not toggle tab bar
visibility
https://bugs.webkit.org/show_bug.cgi?id=228086

Attachment 433824: Patch

https://bugs.webkit.org/attachment.cgi?id=433824&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 433824
  --> https://bugs.webkit.org/attachment.cgi?id=433824
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433824&action=review

r=me

>> Source/WebKit/ChangeLog:9
>> +	    Treat taps over elements that are explicitly marked draggable and
also respond to click events as "meaningful"
> 
> Is the "and also respond to click events" detail in this patch, or in
pre-existing code?

I see: The caller ensures nodeRespondingToClickEvents().


More information about the webkit-reviews mailing list