[webkit-reviews] review granted: [Bug 227915] Port dialog close event to modern event handling code : [Attachment 433818] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 19 13:30:16 PDT 2021

Chris Dumez <cdumez at apple.com> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 227915: Port dialog close event to modern event handling code

Attachment 433818: Patch


--- Comment #9 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 433818
  --> https://bugs.webkit.org/attachment.cgi?id=433818

View in context: https://bugs.webkit.org/attachment.cgi?id=433818&action=review

r=me with nit. Please make sure the bots are happy before landing.

> Source/WebCore/html/HTMLDialogElement.cpp:93
> +    document().eventLoop().queueTask(TaskSource::UserInteraction,
[protectedThis = GCReachableRef<HTMLDialogElement>(*this)] {

With C++17, you can probably write: `protectedThis = GCReachableRef { *this }`

More information about the webkit-reviews mailing list