[webkit-reviews] review granted: [Bug 228040] [JSC] Simplify sampling-profiler-regexp.js test : [Attachment 433712] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 16 16:03:35 PDT 2021
Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 228040: [JSC] Simplify sampling-profiler-regexp.js test
https://bugs.webkit.org/show_bug.cgi?id=228040
Attachment 433712: Patch
https://bugs.webkit.org/attachment.cgi?id=433712&action=review
--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 433712
--> https://bugs.webkit.org/attachment.cgi?id=433712
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=433712&action=review
> JSTests/stress/sampling-profiler/samplingProfiler.js:37
> +const VERBOSE = true;
id you want to check this part in?
> JSTests/stress/sampling-profiler/samplingProfiler.js:69
> if (isRunFromRunTest)
> - stackTrace = [...stackTrace, "runTest", "(program)"];
> + stackTrace = [...stackTraceOrString, "runTest", "(program)"];
> else
> - stackTrace = [...stackTrace];
> + stackTrace = [...stackTraceOrString];
does this make sense if the stack trace is a string?
More information about the webkit-reviews
mailing list