[webkit-reviews] review granted: [Bug 227970] Add ExtendType to Air::Arg Index to fully utilize address computation in memory instruction for ARM64 : [Attachment 433706] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yijia Huang
<yijia_huang at apple.com>'s request for review:
Bug 227970: Add ExtendType to Air::Arg Index to fully utilize address
computation in memory instruction for ARM64
https://bugs.webkit.org/show_bug.cgi?id=227970

Attachment 433706: Patch

https://bugs.webkit.org/attachment.cgi?id=433706&action=review




--- Comment #17 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 433706
  --> https://bugs.webkit.org/attachment.cgi?id=433706
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433706&action=review

r=me with comments

> Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:128
> +    enum Extend : uint8_t {

enum class

> Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:228
> +#if CPU(X86) || CPU(X86_64)
> +	       ASSERT(extend == None);
> +#endif

Sorry, I know I said differently earlier. But since you only support this on
arm64, I think I'd actually do this as:

#if !CPU(ARM64)

> Source/JavaScriptCore/b3/B3LowerToAir.cpp:577
> +		   return indexArg(tmp(base), index->child(0), *scale, offset);

can we add a test for add here?