[webkit-reviews] review granted: [Bug 227333] Build Default Metal library offline, and install to WebCore Resources : [Attachment 433693] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 16 13:54:16 PDT 2021
Dean Jackson <dino at apple.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 227333: Build Default Metal library offline, and install to WebCore
Resources
https://bugs.webkit.org/show_bug.cgi?id=227333
Attachment 433693: Patch
https://bugs.webkit.org/attachment.cgi?id=433693&action=review
--- Comment #26 from Dean Jackson <dino at apple.com> ---
Comment on attachment 433693
--> https://bugs.webkit.org/attachment.cgi?id=433693
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=433693&action=review
> Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj:3704
> + shellScript = "if [ \"${ACTION}\" = \"build\" ] || [
\"${ACTION}\" = \"install\" ]; then\necho python
\"${SRCROOT}/src/libANGLE/renderer/metal/shaders/create_mtl_internal_shaders.py
\" \"$SCRIPT_INPUT_FILE_0\" \"$SCRIPT_OUTPUT_FILE_0\"\npython
\"${SRCROOT}/src/libANGLE/renderer/metal/shaders/create_mtl_internal_shaders.py
\" \"$SCRIPT_INPUT_FILE_0\" \"$SCRIPT_OUTPUT_FILE_0\"\nfi\n";
We probably don't need to echo the command, but that's ok.
More information about the webkit-reviews
mailing list