[webkit-reviews] review denied: [Bug 228008] Add support for MediaError.message : [Attachment 433634] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 15 17:27:20 PDT 2021

Alex Christensen <achristensen at apple.com> has denied Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 228008: Add support for MediaError.message

Attachment 433634: Patch


--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 433634
  --> https://bugs.webkit.org/attachment.cgi?id=433634

View in context: https://bugs.webkit.org/attachment.cgi?id=433634&action=review

>> Source/WebCore/html/HTMLMediaElement.cpp:2072
>> +	m_error = MediaError::create(MediaError::MEDIA_ERR_SRC_NOT_SUPPORTED,
"Unsupported source type"_s);
> Do Chrome and Firefox use these same strings?

Can these strings be derived from m_code instead of storing an additional
String an increasing the size of MediaError?

More information about the webkit-reviews mailing list