[webkit-reviews] review granted: [Bug 228003] JITWorklist::waitUntilAllPlansForVMAreReady() should also be notified when plans are cancelled. : [Attachment 433619] proposed patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 15 13:32:05 PDT 2021
Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 228003: JITWorklist::waitUntilAllPlansForVMAreReady() should also be
notified when plans are cancelled.
https://bugs.webkit.org/show_bug.cgi?id=228003
Attachment 433619: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=433619&action=review
--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 433619
--> https://bugs.webkit.org/attachment.cgi?id=433619
proposed patch.
View in context: https://bugs.webkit.org/attachment.cgi?id=433619&action=review
r=me
> Source/JavaScriptCore/jit/JITWorklist.cpp:336
> + bool didCancelPlans = deadPlanKeys.size();
Using !isEmpty() would be better.
More information about the webkit-reviews
mailing list