[webkit-reviews] review granted: [Bug 208204] [GTK][WPE] Support color-schemes CSS property? : [Attachment 433589] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Alexander Mikhaylenko
<alexm at gnome.org>'s request for review:
Bug 208204: [GTK][WPE] Support color-schemes CSS property?
https://bugs.webkit.org/show_bug.cgi?id=208204

Attachment 433589: Patch

https://bugs.webkit.org/attachment.cgi?id=433589&action=review




--- Comment #20 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 433589
  --> https://bugs.webkit.org/attachment.cgi?id=433589
Patch

This looks great, well done getting through all the churn to get the colors
and theme rendering working with the dark color scheme \o/

View in context: https://bugs.webkit.org/attachment.cgi?id=433589&action=review

> Source/WebCore/css/themeAdwaita.css:29
> +    -webkit-mask-image: url("data:image/svg+xml;utf-8, \

TIL about CSS mask-image ^_^

> Source/WebCore/platform/adwaita/ThemeAdwaita.cpp:304
> +

This addition of an empty line is not needed, please leave it out before
landing :)

> Source/WebCore/platform/adwaita/ThemeAdwaita.cpp:523
> +

Ditto for this empty line.