[webkit-reviews] review granted: [Bug 227914] Pipe App Highlight scrolling through UI Process in preparation for Note Overlay avoidance. : [Attachment 433553] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 14 19:01:55 PDT 2021


Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 227914: Pipe App Highlight scrolling through UI Process in preparation for
Note Overlay avoidance.
https://bugs.webkit.org/show_bug.cgi?id=227914

Attachment 433553: Patch

https://bugs.webkit.org/attachment.cgi?id=433553&action=review




--- Comment #29 from Tim Horton <thorton at apple.com> ---
Comment on attachment 433553
  --> https://bugs.webkit.org/attachment.cgi?id=433553
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433553&action=review

> Source/WebKit/UIProcess/ios/PageClientImplIOS.h:218
> +    void requestScrollToRect(const WebCore::FloatRect& targetRect, const
WebCore::FloatPoint& origin) override;

Not sure why this is clinging to the comment below


More information about the webkit-reviews mailing list