[webkit-reviews] review granted: [Bug 227965] Link against Catalyst ANGLE-shared.dylib when linking Catalyst WebCore.framework : [Attachment 433519] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 227965: Link against Catalyst ANGLE-shared.dylib when linking Catalyst
WebCore.framework
https://bugs.webkit.org/show_bug.cgi?id=227965

Attachment 433519: Patch

https://bugs.webkit.org/attachment.cgi?id=433519&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 433519
  --> https://bugs.webkit.org/attachment.cgi?id=433519
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433519&action=review

> Source/WebCore/ChangeLog:11
> +	   At runtime, though, we realize we are opening the wrong dylib and
bad things happen.

I don't think we do notice, actually, it just has a few critical #ifdeffed
behavioral differences that break things :)

> Source/WebCore/ChangeLog:13
> +	   The solution is to look in the Catalyst WebCore framework directory
when WK_USE_ALTERNATE_FRAMEWORKS_DIR is YES,

No idea how I missed this one years ago, I'm surprised it hadn't come up
before! Thank you.