[webkit-reviews] review granted: [Bug 227962] Check for out of memory in JSC::globalFuncEscape() and JSC::globalFuncUnescape(). : [Attachment 433514] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 227962: Check for out of memory in JSC::globalFuncEscape() and
JSC::globalFuncUnescape().
https://bugs.webkit.org/show_bug.cgi?id=227962

Attachment 433514: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=433514&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 433514
  --> https://bugs.webkit.org/attachment.cgi?id=433514
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=433514&action=review

r=me

> Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:616
> +	       return vm.smallStrings.emptyString();

Why not returning `{ }`?

> Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:679
> +	       return vm.smallStrings.emptyString();

Why not returning `{ }` ?