[webkit-reviews] review granted: [Bug 227957] [BMalloc] Lazily allocate physical pages : [Attachment 433509] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 227957: [BMalloc] Lazily allocate physical pages
https://bugs.webkit.org/show_bug.cgi?id=227957

Attachment 433509: Patch

https://bugs.webkit.org/attachment.cgi?id=433509&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 433509
  --> https://bugs.webkit.org/attachment.cgi?id=433509
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433509&action=review

r=me

> Source/bmalloc/bmalloc/VMAllocate.h:-218
> -    SYSCALL(madvise(p, vmSize, MADV_FREE_REUSE));

nit: Can you put the comment blurb from your ChangeLog in here about DARWIN not
needing this madvise?  Otherwise, I can see someone not-in-the-know naively
re-adding this back in the future with no visible immediate fallout to provide
feedback that it should not be done.