[webkit-reviews] review granted: [Bug 227914] Pipe App Highlight scrolling through UI Process in preparation for Note Pip avoidance. : [Attachment 433471] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 227914: Pipe App Highlight scrolling through UI Process in preparation for
Note Pip avoidance.
https://bugs.webkit.org/show_bug.cgi?id=227914

Attachment 433471: Patch

https://bugs.webkit.org/attachment.cgi?id=433471&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 433471
  --> https://bugs.webkit.org/attachment.cgi?id=433471
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433471&action=review

> Source/WebCore/ChangeLog:8
> +	   In order to correctly avoid the note pip that can potentially
obscure the web view,

I feel like pip should be PIP or have another name because it's not Picture in
Picture. Overlay? Popover?

> Source/WebCore/page/ChromeClient.h:231
> +    virtual void scrollRectInMainFrameIntoView(const IntRect&) const { }; //
Currently only Mac has a non empty implementation.

scrollMainFrameToRevealRect ?

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:1420
> +void WebProcess::scrollToRect(WebCore::FloatRect targetRect,
WebCore::FloatPoint origin)

Might warn about origin being unused.