[webkit-reviews] review granted: [Bug 227916] [WK2] Push OS state dumping logic down from WebProcess to AuxiliaryProcess : [Attachment 433445] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 227916: [WK2] Push OS state dumping logic down from WebProcess to
AuxiliaryProcess
https://bugs.webkit.org/show_bug.cgi?id=227916

Attachment 433445: Patch

https://bugs.webkit.org/attachment.cgi?id=433445&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 433445
  --> https://bugs.webkit.org/attachment.cgi?id=433445
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433445&action=review

> Source/WebKit/WebProcess/WebProcess.h:413
> +    RetainPtr<NSDictionary> dictionaryForStateDumper() const final;

Can we make it more clear in the name what this is about? Every time I have
encountered this function before it was wildly unclear what state was being
dumped and why.