[webkit-reviews] review granted: [Bug 227923] REGRESSION(r279069): http/tests/websocket/tests/hybi/too-long-payload.html is a constant timeout when using NSURLSESSION_WEBSOCKET : [Attachment 433449] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 13 15:08:06 PDT 2021


Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 227923: REGRESSION(r279069):
http/tests/websocket/tests/hybi/too-long-payload.html is a constant timeout
when using NSURLSESSION_WEBSOCKET
https://bugs.webkit.org/show_bug.cgi?id=227923

Attachment 433449: Patch

https://bugs.webkit.org/attachment.cgi?id=433449&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 433449
  --> https://bugs.webkit.org/attachment.cgi?id=433449
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433449&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1697
> +    task.get().maximumMessageSize = 0x7FFFFFFFFFFFFFFFull;

Maybe worth a comment to indicate why you chose this value.


More information about the webkit-reviews mailing list