[webkit-reviews] review granted: [Bug 227579] Bundle libraries for remote execution in run-jsc-benchmarks : [Attachment 433319] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has granted Angelos
Oikonomopoulos <angelos at igalia.com>'s request for review:
Bug 227579: Bundle libraries for remote execution in run-jsc-benchmarks
https://bugs.webkit.org/show_bug.cgi?id=227579

Attachment 433319: Patch

https://bugs.webkit.org/attachment.cgi?id=433319&action=review




--- Comment #9 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 433319
  --> https://bugs.webkit.org/attachment.cgi?id=433319
Patch

Patch looks fine! thanks!
BTW, a suggestion to make the bundle-binary script jhbuild/flatpak aware is
this diff over your patch: http://sprunge.us/BB3T7i
It adds an optional platform parameter, that when enabled will try to detect
jhbuild/flatpak detection on gtk/wpe ports.
So it looks for libraries inside the flatpak container or the jhbuild
directories.
If platform is not passed (like when called from the run-jsc-benchmark script
then it behaves like now.. doesn't try to detect jhbuild/flatpak which is not
used on javascriptonly builds)