[webkit-reviews] review granted: [Bug 227825] Allow layout tests to specify app initiated loads or not : [Attachment 433353] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Kate Cheney
<katherine_cheney at apple.com>'s request for review:
Bug 227825: Allow layout tests to specify app initiated loads or not
https://bugs.webkit.org/show_bug.cgi?id=227825

Attachment 433353: Patch

https://bugs.webkit.org/attachment.cgi?id=433353&action=review




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 433353
  --> https://bugs.webkit.org/attachment.cgi?id=433353
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433353&action=review

R=me, but consider using a HAVE macro, perhaps in a follow up patch, to gate
this on the presence of app initiation state in a build, rather than OS family,

> Source/WebKit/UIProcess/API/APIPageConfiguration.cpp:99
> +#if PLATFORM(IOS_FAMILY)

This might be better as a HAVE macro (e.g., HAVE(APP_ATTRIBUTION) or
something).