[webkit-reviews] review denied: [Bug 227510] Add a new Air::Arg kind ZeroReg to let AIR recognise the new instructions/forms accepting zero register in ARM64 : [Attachment 433339] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 12 20:40:59 PDT 2021


Saam Barati <sbarati at apple.com> has denied Yijia Huang
<yijia_huang at apple.com>'s request for review:
Bug 227510: Add a new Air::Arg kind ZeroReg to let AIR recognise the new
instructions/forms accepting zero register in ARM64
https://bugs.webkit.org/show_bug.cgi?id=227510

Attachment 433339: Patch

https://bugs.webkit.org/attachment.cgi?id=433339&action=review




--- Comment #19 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 433339
  --> https://bugs.webkit.org/attachment.cgi?id=433339
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433339&action=review

Seems like you introduced a lot of test failures.

> Source/JavaScriptCore/b3/air/AirArg.h:760
> +	   case ZeroReg:

should be false

> Source/JavaScriptCore/b3/air/AirLowerStackArgs.cpp:160
> +			       RELEASE_ASSERT(isValidForm(Store32,
Arg::ZeroReg, Arg::Stack));

was this run on x86 before? If so, gotta keep something around for x86. 

If so, could keep around StoreZero for x86.


More information about the webkit-reviews mailing list