[webkit-reviews] review granted: [Bug 227857] Add SMNEGL, UMNEGL, UMADDL, and UMSUBL for ARM64 and select this instruction in Air : [Attachment 433343] Patch

[bugzilla-daemon at webkit.org]

Robin Morisset <rmorisset at apple.com> has granted Yijia Huang
<yijia_huang at apple.com>'s request for review:
Bug 227857: Add SMNEGL, UMNEGL, UMADDL, and UMSUBL for ARM64 and select this
instruction in Air
https://bugs.webkit.org/show_bug.cgi?id=227857

Attachment 433343: Patch

https://bugs.webkit.org/attachment.cgi?id=433343&action=review




--- Comment #6 from Robin Morisset <rmorisset at apple.com> ---
Comment on attachment 433343
  --> https://bugs.webkit.org/attachment.cgi?id=433343
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433343&action=review

r=me

> Source/JavaScriptCore/b3/B3LowerToAir.cpp:2766
> +		       // ZMNEG: d = -(ZExt32(n) * ZExt32(m))

nitpick: ZMNEG -> UMNEG