[webkit-reviews] review granted: [Bug 227858] [Line layout] "zero width space" (U+200B) is a breaking space : [Attachment 433297] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 12 08:35:13 PDT 2021


Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 227858: [Line layout] "zero width space" (U+200B) is a breaking space
https://bugs.webkit.org/show_bug.cgi?id=227858

Attachment 433297: Patch

https://bugs.webkit.org/attachment.cgi?id=433297&action=review




--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 433297
  --> https://bugs.webkit.org/attachment.cgi?id=433297
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433297&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:59
> +    if (curentContent.is8Bit() && !previousContent.is8Bit())
> +	   curentContent =
String::make16BitFrom8BitSource(curentContent.characters8(),
curentContent.length());

Could use a comment.


More information about the webkit-reviews mailing list