[webkit-reviews] review granted: [Bug 227855] [JSC] Workaround test262.report bug by making $ properties enumerable : [Attachment 433277] Patch

[bugzilla-daemon at webkit.org]

Alexey Shvayka <shvaikalesh at gmail.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 227855: [JSC] Workaround test262.report bug by making $ properties
enumerable
https://bugs.webkit.org/show_bug.cgi?id=227855

Attachment 433277: Patch

https://bugs.webkit.org/attachment.cgi?id=433277&action=review




--- Comment #2 from Alexey Shvayka <shvaikalesh at gmail.com> ---
Comment on attachment 433277
  --> https://bugs.webkit.org/attachment.cgi?id=433277
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433277&action=review

> Source/JavaScriptCore/ChangeLog:8
> +	   test262.report's harness has a bug and it reports incorrect results
for JSC on tests using $262 properties.

Is it a bug though?
https://github.com/tc39/test262/blob/main/INTERPRETING.md#host-defined-function
s requires $262 and print to be non-enumerable (which they are), yet it doesn't
clarify attributes of $262 properties. "ordinary object with the following
properties" kinda implies PropertyAttribute::None to me. Should we author a PR
to clarify it?