[webkit-reviews] review granted: [Bug 227145] [iOS] Increase contrast for textfields, checkboxes, and radio buttons : [Attachment 433160] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 227145: [iOS] Increase contrast for textfields, checkboxes, and radio
buttons
https://bugs.webkit.org/show_bug.cgi?id=227145

Attachment 433160: Patch

https://bugs.webkit.org/attachment.cgi?id=433160&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 433160
  --> https://bugs.webkit.org/attachment.cgi?id=433160
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433160&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:2090
> +

Nit - you could probably pull `checkboxRadioBackgroundColor(controlStates,
styleColorOptions)` out into a local variable here to avoid writing it out
twice.

> Source/WebCore/rendering/RenderThemeIOS.mm:2155
> +	   context.setFillColor(checkboxRadioBackgroundColor(controlStates,
styleColorOptions));

(Ditto)