[webkit-reviews] review granted: [Bug 227691] [GTK] Touchscreen navigation swipe doesn't work when the page scrolls horizontally : [Attachment 433148] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Alexander Mikhaylenko
<alexm at gnome.org>'s request for review:
Bug 227691: [GTK] Touchscreen navigation swipe doesn't work when the page
scrolls horizontally
https://bugs.webkit.org/show_bug.cgi?id=227691

Attachment 433148: Patch

https://bugs.webkit.org/attachment.cgi?id=433148&action=review




--- Comment #9 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 433148
  --> https://bugs.webkit.org/attachment.cgi?id=433148
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433148&action=review

> Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp:444
> +    // Wheel events can have either scroll events or touch events attached
to them.
> +    // We only want to propagate scroll events; touch events are controlled
via their
> +    // event sequences and if we're scrolling with touch events, that
sequence is
> +    // already claimed and there's no point in propagating it.

Thanks for adding a comment to explain the weird behavior.