[webkit-reviews] review granted: [Bug 227571] [WebIDL] Add BigInt64Array and BigUint64Array support to IDL bindings generator : [Attachment 433168] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 227571: [WebIDL] Add BigInt64Array and BigUint64Array support to IDL
bindings generator
https://bugs.webkit.org/show_bug.cgi?id=227571

Attachment 433168: Patch

https://bugs.webkit.org/attachment.cgi?id=433168&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 433168
  --> https://bugs.webkit.org/attachment.cgi?id=433168
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433168&action=review

> Source/WebCore/ChangeLog:3
> +	   [WebIDL] Add BigInt64Array and BigUint64Array support to IDL
bindings generator

The title is misleading, this seems to only be fixing a bug in the streams
implementation?

This does not impact the bindings generator in any way. Streams is not using
the IDL binding generator (unfortunately).

> Source/WebCore/Modules/streams/ReadableStreamInternals.js:460
> +		  
@readableStreamDefaultControllerEnqueue(teeState.branch2. at readableStreamControl
ler, shouldClone ? @structuredCloneForFetch(result.value) : result.value);

Why is this called structuredCloneForFetch? Did you mean
structuredCloneForStream?