[webkit-reviews] review granted: [Bug 227806] Fix some whitespace handling issues in URL setters : [Attachment 433163] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 8 15:35:48 PDT 2021


Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 227806: Fix some whitespace handling issues in URL setters
https://bugs.webkit.org/show_bug.cgi?id=227806

Attachment 433163: Patch

https://bugs.webkit.org/attachment.cgi?id=433163&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 433163
  --> https://bugs.webkit.org/attachment.cgi?id=433163
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433163&action=review

> Source/WebCore/html/URLDecomposition.cpp:176
> +    for (size_t i = 0; i < string.length(); ++i) {

could use unsigned instead of size_t since that's what string.length() returns.


More information about the webkit-reviews mailing list