[webkit-reviews] review denied: [Bug 227816] REGRESSION(r277571) null dereference in SQLiteStatement::~SQLiteStatement : [Attachment 433165] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 8 14:40:59 PDT 2021


Chris Dumez <cdumez at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 227816: REGRESSION(r277571) null dereference in
SQLiteStatement::~SQLiteStatement
https://bugs.webkit.org/show_bug.cgi?id=227816

Attachment 433165: Patch

https://bugs.webkit.org/attachment.cgi?id=433165&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 433165
  --> https://bugs.webkit.org/attachment.cgi?id=433165
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433165&action=review

> Source/WebCore/platform/sql/SQLiteStatement.cpp:62
> +	   sqlite3_finalize(m_statement);

https://www.sqlite.org/c3ref/finalize.html:
"Invoking sqlite3_finalize() on a NULL pointer is a harmless no-op."


More information about the webkit-reviews mailing list