[webkit-reviews] review denied: [Bug 227579] Bundle libraries for remote execution in run-jsc-benchmarks : [Attachment 432792] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has denied Angelos
Oikonomopoulos <angelos at igalia.com>'s request for review:
Bug 227579: Bundle libraries for remote execution in run-jsc-benchmarks
https://bugs.webkit.org/show_bug.cgi?id=227579

Attachment 432792: Patch

https://bugs.webkit.org/attachment.cgi?id=432792&action=review




--- Comment #5 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 432792
  --> https://bugs.webkit.org/attachment.cgi?id=432792
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432792&action=review

The code looks fine, however when I tested it I found unexpected errors.. that
is why I'm setting r-

It seems that generating the MiniBrowser bundle with generate-bundle is broken
after this patch

$ Tools/Scripts/generate-bundle --platform wpe --release --bundle MiniBrowser 
Traceback (most recent call last):
  File "Tools/Scripts/generate-bundle", line 606, in <module>
    sys.exit(main())
  File "Tools/Scripts/generate-bundle", line 596, in main
    bundle_file_path = bundle_creator.create()
  File "Tools/Scripts/generate-bundle", line 254, in create
    self._create_bundle(bundle_binary)
  File "Tools/Scripts/generate-bundle", line 388, in _create_bundle
    gio_modules = self._get_gio_modules()
  File "Tools/Scripts/generate-bundle", line 327, in _get_gio_modules
    retcode, stdout, stderr = self._run_cmd_and_get_output(['pkg-config',
'--variable=giomoduledir', 'gio-2.0'])
AttributeError: 'BundleCreator' object has no attribute
'_run_cmd_and_get_output'

> Tools/Scripts/bundle-binary:1
> +#!/usr/bin/env python3

Please add the usual copyright boilerplate at the top of each new code file, is
the policy of the project to do that.

> Tools/Scripts/webkitpy/binary_bundling/bundle.py:1
> +import logging

Missing copyright boilerplate also here

> Tools/Scripts/webkitpy/binary_bundling/ldd.py:1
> +import logging

Also missing copyright