[webkit-reviews] review granted: [Bug 227550] [GPU Process] Draw PDFs using an intermediate ImageBuffer when using the GPU process : [Attachment 432982] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 227550: [GPU Process] Draw PDFs using an intermediate ImageBuffer when
using the GPU process
https://bugs.webkit.org/show_bug.cgi?id=227550

Attachment 432982: Patch

https://bugs.webkit.org/attachment.cgi?id=432982&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 432982
  --> https://bugs.webkit.org/attachment.cgi?id=432982
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432982&action=review

> Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp:165
> +    // FIXME: Surely there needs to be a clip operation here, if the srcRect
is smaller than the whole PDF.

BUG #

> Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp:251
> +    // FIXME: Passing in m_cachedImageRect.location() for the source rect
position is confusing here.

BUG # (also, "confusing" or "wrong"? I thought you had a test page that
indicated the latter, which also should go in the BUG!)

> Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp:286
> +	       // We also need to be careful about not getting jetsam'ed.

I would expand "jetsam'ed" out to "terminated due to memory pressure" or
something.