[webkit-reviews] review granted: [Bug 227509] Add Air opcode add/sub-and-shift for ARM64 and select this instruction in Air : [Attachment 433118] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yijia Huang
<yijia_huang at apple.com>'s request for review:
Bug 227509: Add Air opcode add/sub-and-shift for ARM64 and select this
instruction in Air
https://bugs.webkit.org/show_bug.cgi?id=227509

Attachment 433118: Patch

https://bugs.webkit.org/attachment.cgi?id=433118&action=review




--- Comment #16 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 433118
  --> https://bugs.webkit.org/attachment.cgi?id=433118
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433118&action=review

Nice. r=me

> Source/JavaScriptCore/b3/testb3_2.cpp:4148
> +	       checkUsesInstruction(*code, toCString("add      w0, w0, w1, lsl
#", amount).data());

I'd be a bit wary of relying on the register allocator always allocating in
these registers. Can't we just use a regexp here instead? I think Keith added a
way to do that at some point.

Ditto to all the checks below.