[webkit-reviews] review granted: [Bug 227591] Add logging for legacy AppHighlight decoding to aid in future debugging. : [Attachment 433136] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 227591: Add logging for legacy AppHighlight decoding to aid in future
debugging.
https://bugs.webkit.org/show_bug.cgi?id=227591

Attachment 433136: Patch

https://bugs.webkit.org/attachment.cgi?id=433136&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 433136
  --> https://bugs.webkit.org/attachment.cgi?id=433136
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433136&action=review

> Source/WebCore/Modules/highlight/AppHighlightStorage.cpp:136
> +    RELEASE_LOG(AppHighlights, "Attempting fallback text search for
AppHighlightRangeData.");

Do you need to `#include Logging.h` in this file as well?

(I suspect it's currently grabbing it from the AppHighlightRangeData.cpp here,
since it's right before this file in unified sources).