[webkit-reviews] review denied: [Bug 227778] Suspend WebIDBServer when assertion in network is going to be invalidated : [Attachment 433116] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 227778: Suspend WebIDBServer when assertion in network is going to be
invalidated
https://bugs.webkit.org/show_bug.cgi?id=227778

Attachment 433116: Patch

https://bugs.webkit.org/attachment.cgi?id=433116&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 433116
  --> https://bugs.webkit.org/attachment.cgi?id=433116
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433116&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:-2219
> -    for (auto& server : m_webIDBServers.values())

Not suspending the IDB thread in PrepareToSuspend seems like a big no-no.