[webkit-reviews] review granted: [Bug 227783] add logging for GraphicsLayerCA::m_uncommittedChanges : [Attachment 433102] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Cameron McCormack
(:heycam) <heycam at apple.com>'s request for review:
Bug 227783: add logging for GraphicsLayerCA::m_uncommittedChanges
https://bugs.webkit.org/show_bug.cgi?id=227783

Attachment 433102: Patch

https://bugs.webkit.org/attachment.cgi?id=433102&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 433102
  --> https://bugs.webkit.org/attachment.cgi?id=433102
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433102&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:4207
> +    bool first = true;
> +    while (layerChangeFlags) {
> +	   if (layerChangeFlags & bit) {
> +	       textStream << (first ? " " : ", ") <<
layerChangeAsString(static_cast<LayerChange>(bit));
> +	       first = false;
> +	   }
> +	   layerChangeFlags &= ~bit;
> +	   bit <<= 1;
> +    }
> +    textStream << " }";

Shame that LayerChangeFlags isn' an OptionSet<> because they you wouldn't need
this either.