[webkit-reviews] review granted: [Bug 227656] [OpenSSL] Implement HKDF and PBKDF2 support : [Attachment 433097] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 7 17:55:41 PDT 2021

Fujii Hironori <Hironori.Fujii at sony.com> has granted Yoshiaki Jitsukawa
<yoshiaki.jitsukawa at sony.com>'s request for review:
Bug 227656: [OpenSSL] Implement HKDF and PBKDF2 support

Attachment 433097: Patch


--- Comment #3 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 433097
  --> https://bugs.webkit.org/attachment.cgi?id=433097

View in context: https://bugs.webkit.org/attachment.cgi?id=433097&action=review

> Source/WebCore/crypto/openssl/CryptoAlgorithmPBKDF2OpenSSL.cpp:49
> +    if (PKCS5_PBKDF2_HMAC((const char*)key.key().data(), key.key().size(),
parameters.saltVector().data(), parameters.saltVector().size(),
parameters.iterations, algorithm, output.size(), output.data()) <= 0)

Even though WebKit code style guideline doesn't mention, some reviewer dislikes
C-style case. You should use C++-style cast. Unfortunately, it's
reinterpret_cast in this case.

More information about the webkit-reviews mailing list