[webkit-reviews] review granted: [Bug 227767] fitcored crashes at JavaScriptCore: JSC::Heap::releaseAccessSlow : [Attachment 433066] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 227767: fitcored crashes at JavaScriptCore: JSC::Heap::releaseAccessSlow
https://bugs.webkit.org/show_bug.cgi?id=227767

Attachment 433066: Patch

https://bugs.webkit.org/attachment.cgi?id=433066&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 433066
  --> https://bugs.webkit.org/attachment.cgi?id=433066
Patch

r=me

Is it ever correct to have heap access when we run the VM destructor? I think
it is not. So, I think the VM destructor should RELEASE_ASSERT !hasAccess().

(I'm asking because that RELEASE_ASSERT would remove all the speculation in
your reasoning.)