[webkit-reviews] review granted: [Bug 227735] Add WKHoverPlatter and some knobs to tweak its appearance : [Attachment 433019] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 227735: Add WKHoverPlatter and some knobs to tweak its appearance
https://bugs.webkit.org/show_bug.cgi?id=227735

Attachment 433019: Patch

https://bugs.webkit.org/attachment.cgi?id=433019&action=review




--- Comment #8 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 433019
  --> https://bugs.webkit.org/attachment.cgi?id=433019
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433019&action=review

> Source/WebKit/UIProcess/ios/WKHoverPlatter.mm:40
> +	   RetainPtr<CASpringAnimation> spring = adoptNS([[CASpringAnimation
alloc] init]);

auto?

> Source/WebKit/UIProcess/ios/WKHoverPlatter.mm:49
> +    RetainPtr<CABasicAnimation> ease = adoptNS([[CABasicAnimation alloc]
init]);

auto?

> Source/WebKit/UIProcess/ios/WKHoverPlatter.mm:58
> +    RetainPtr<CABasicAnimation> animation = createBaseAnimation();

auto?

> Source/WebKit/UIProcess/ios/WKHoverPlatter.mm:189
> +    RetainPtr<CGPathRef> inflatedPath =
WebCore::PathUtilities::pathWithShrinkWrappedRects(inflatedIndicatedRects,
parameters.platterCornerRadius).platformPath();

auto?