[webkit-reviews] review granted: [Bug 227502] [PlayStation] Don't assume 4KB block size when estimating Network Cache disk usage : [Attachment 433047] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Christopher Reid
<chris.reid at sony.com>'s request for review:
Bug 227502: [PlayStation] Don't assume 4KB block size when estimating Network
Cache disk usage
https://bugs.webkit.org/show_bug.cgi?id=227502

Attachment 433047: Patch

https://bugs.webkit.org/attachment.cgi?id=433047&action=review




--- Comment #20 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 433047
  --> https://bugs.webkit.org/attachment.cgi?id=433047
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433047&action=review

r=me with nits.

> Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:166
> +    uint32_t volumeBlockSize();

nit: I would mark this as const.

> Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:176
> +    uint32_t m_volumeBlockSize { 0 };

nit: I would mark this as mutable since it is computed lazily in the getter.
Also, I'd using an std::optional<> instead of a magic value of 0 when unknown.