[webkit-reviews] review granted: [Bug 227747] XPC services should release their os transaction when given a SIGTERM signal : [Attachment 433035] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 7 09:41:54 PDT 2021


Geoffrey Garen <ggaren at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 227747: XPC services should release their os transaction when given a
SIGTERM signal
https://bugs.webkit.org/show_bug.cgi?id=227747

Attachment 433035: Patch

https://bugs.webkit.org/attachment.cgi?id=433035&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 433035
  --> https://bugs.webkit.org/attachment.cgi?id=433035
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433035&action=review

r=me

>
Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.
h:105
> +    signal(SIGTERM, releaseOSTransaction);

FWIW, I like using no-capture lambdas in cases like this.


More information about the webkit-reviews mailing list