[webkit-reviews] review granted: [Bug 227594] [Legacy line layout] Inline content on subpixel position makes the table cell scroll : [Attachment 433024] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 227594: [Legacy line layout] Inline content on subpixel position makes the
table cell scroll
https://bugs.webkit.org/show_bug.cgi?id=227594

Attachment 433024: Patch

https://bugs.webkit.org/attachment.cgi?id=433024&action=review




--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 433024
  --> https://bugs.webkit.org/attachment.cgi?id=433024
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433024&action=review

> Source/WebCore/rendering/LegacyInlineFlowBox.cpp:659
> +	   // FIXME: Let's do device pixel snapping at paint time instead.

Can you reference a bugzilla bug in the comment? The "Let's do" makes it hard
to judge how important this is; it should be more like "we should not do
integral rounding here".

> Source/WebCore/rendering/LegacyInlineFlowBox.cpp:771
>      if (isRootBox) {

Sucks how there's if (isRootBox) logic way up at the start of this function,
and here. Would be nice to factor the middle part into separate function.