[webkit-reviews] review granted: [Bug 227742] Set Caption preferences in the UI process : [Attachment 433029] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 7 08:35:44 PDT 2021


Eric Carlson <eric.carlson at apple.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 227742: Set Caption preferences in the UI process
https://bugs.webkit.org/show_bug.cgi?id=227742

Attachment 433029: Patch

https://bugs.webkit.org/attachment.cgi?id=433029&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 433029
  --> https://bugs.webkit.org/attachment.cgi?id=433029
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433029&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:5527
> -		FD3160BF12B0272A00C1A359 /* AudioFileReaderMac.h in Headers */
= {isa = PBXBuildFile; fileRef = FD3160B912B0272A00C1A359 /*
AudioFileReaderMac.h */; };
> +		FD3160BF12B0272A00C1A359 /* (null) in Headers */ = {isa =
PBXBuildFile; };

Nit: this seems unintentional

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:31619
> +				FD3160BF12B0272A00C1A359 /* (null) in Headers
*/,

Ditto


More information about the webkit-reviews mailing list