[webkit-reviews] review requested: [Bug 227722] Fix type error in testb3 : [Attachment 432976] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 6 14:54:48 PDT 2021


Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 227722: Fix type error in testb3
https://bugs.webkit.org/show_bug.cgi?id=227722

Attachment 432976: Patch

https://bugs.webkit.org/attachment.cgi?id=432976&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 432976
  --> https://bugs.webkit.org/attachment.cgi?id=432976
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432976&action=review

> Source/JavaScriptCore/b3/testb3_3.cpp:93
>	   Value* lsbValue = root->appendNew<Const32Value>(proc, Origin(),
lsb);
> -	   Value* amountValue = root->appendNew<Const64Value>(proc, Origin(),
amount);
> +	   Value* amountValue = root->appendNew<Const32Value>(proc, Origin(),
amount);

Why pass lab and amount in as int64_t then?  Ditto for lsbs and widths vectors,
why Vector<int64_t>?


More information about the webkit-reviews mailing list