[webkit-reviews] review denied: [Bug 227718] FormData event handler addition : [Attachment 432970] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 6 14:02:42 PDT 2021
Chris Dumez <cdumez at apple.com> has denied Qiaosong Zhou
<qiaosong_zhou at apple.com>'s request for review:
Bug 227718: FormData event handler addition
https://bugs.webkit.org/show_bug.cgi?id=227718
Attachment 432970: Patch
https://bugs.webkit.org/attachment.cgi?id=432970&action=review
--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 432970
--> https://bugs.webkit.org/attachment.cgi?id=432970
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=432970&action=review
Also missing test or test rebaseline.
> Source/WebCore/ChangeLog:7
> +
Please add detailed change log description.
> Source/WebCore/platform/network/FormData.cpp:96
> + scheduleEvent(eventNames().formdataEvent)
Spec says we should fire an FormDataEvent, not a generic Event.
More information about the webkit-reviews
mailing list