[webkit-reviews] review granted: [Bug 227707] Web Inspector: Elements Tab Details Sidebar navigation items sometime wrap to a second line : [Attachment 432948] Patch v1.0

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 227707: Web Inspector: Elements Tab Details Sidebar navigation items
sometime wrap to a second line
https://bugs.webkit.org/show_bug.cgi?id=227707

Attachment 432948: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=432948&action=review




--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 432948
  --> https://bugs.webkit.org/attachment.cgi?id=432948
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=432948&action=review

r=me, nice fix :)

> Source/WebInspectorUI/ChangeLog:19
> +	    When accumulating item widths, use the ceiling of the width to make
up for slight imprecision in cumulative
> +	   sizing in order to get sizing just a bit larger than the item,
instead of possibly just a bit smaller.

NIT: this is basically a repeat of the above, so I'd either remove the above or
remove this

> Source/WebInspectorUI/UserInterface/Views/NavigationBar.js:226
> +	       return visibleNavigationItems.reduce((total, item) => total +
Math.ceil(item.width), 0);

There's another `navigationItem.width` on :255.  Should we `Math.ceil` that
too?