[webkit-reviews] review granted: [Bug 221620] Make Caches::writeRecord and Caches::readRecord more robust : [Attachment 419748] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 6 02:08:04 PDT 2021
youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 221620: Make Caches::writeRecord and Caches::readRecord more robust
https://bugs.webkit.org/show_bug.cgi?id=221620
Attachment 419748: Patch
https://bugs.webkit.org/attachment.cgi?id=419748&action=review
--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 419748
--> https://bugs.webkit.org/attachment.cgi?id=419748
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=419748&action=review
> Source/WebKit/ChangeLog:9
> + Some events happen during teardown. No reason to crash.
This seems ok to add a null check.
The underlying issue is probably that:
- we request space, which is an asynchronous operation as we may prompt user
- somehow we are requested to clear the caches
- user grants request space and we are back with no available storage.
I think this can be fixed by bailing out early in Caches::requestSpace callback
in case m_isInitialized is false.
More information about the webkit-reviews
mailing list