[webkit-reviews] review granted: [Bug 227677] [JSC] Optimize Object.assign and putDirectInternal : [Attachment 432873] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 227677: [JSC] Optimize Object.assign and putDirectInternal
https://bugs.webkit.org/show_bug.cgi?id=227677

Attachment 432873: Patch

https://bugs.webkit.org/attachment.cgi?id=432873&action=review




--- Comment #4 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 432873
  --> https://bugs.webkit.org/attachment.cgi?id=432873
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432873&action=review

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2941
> +	       // ToObject is idempotent if it succeeds. Plus, it is
non-observable except for the case that an exception is thrown. And when the
exception is thrown,
> +	       // we exit from DFG / FTL. Plus, we keep ordering of these two
ToObject because clobberizing rule says clobberTop. So,
> +	       // we can say exitOK for each ToObject.

If it's only observable when an exception is thrown, then why do you need to
put in ExitOK?