[webkit-reviews] review granted: [Bug 227673] [WebIDL] Use AbortSignal's [PrivateIdentifier] whenSignalAborted() static method : [Attachment 432876] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 227673: [WebIDL] Use AbortSignal's [PrivateIdentifier] whenSignalAborted()
static method
https://bugs.webkit.org/show_bug.cgi?id=227673

Attachment 432876: Patch

https://bugs.webkit.org/attachment.cgi?id=432876&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 432876
  --> https://bugs.webkit.org/attachment.cgi?id=432876
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432876&action=review

>
LayoutTests/imported/w3c/web-platform-tests/streams/piping/abort.any.worker-exp
ected.txt:8
> +FAIL a signal argument '[object AbortSignal]' should cause pipeTo() to
reject Argument 1 ('object') to AbortSignal.whenSignalAborted must be an
instance of AbortSignal

Hum, it seems that our check of (signal instanceof @AbortSignal) is not good
enough since Object.create(AbortSignal.prototype) passes it.
That makes ReadableStream.js pipeTo and pipeThrough not throwing/rejecting when
checking signal while they should do.

We should fix this as a follow-up.
I am not sure what the best way to do is. Is there a better way than adding a
PrivateIdentifier method to AbortSignal itself?