[webkit-reviews] review granted: [Bug 227670] ActiveScratchBufferScope should take the buffer as argument : [Attachment 432859] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 4 00:44:27 PDT 2021

Mark Lam <mark.lam at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 227670: ActiveScratchBufferScope should take the buffer as argument

Attachment 432859: Patch


--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 432859
  --> https://bugs.webkit.org/attachment.cgi?id=432859

View in context: https://bugs.webkit.org/attachment.cgi?id=432859&action=review

r=me with suggested improvement, and if EWS bots are happy.

> Source/JavaScriptCore/dfg/DFGThunks.cpp:94
> -    // Set up one argument.
> +    // Set up two arguments.
>      jit.move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
> +    jit.move(bufferGPR, GPRInfo::argumentGPR1);

Let's just replace this with:
r, bufferGPR);

This has the benefit of ensuring that if bufferGPR happens to be
GPRInfo::argumentGPR0, that it will do the right thing to shuffle the value out
before overwriting it.	And you can also remove the comment now.

> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:1916
> -    
> +

Please undo since there are no other relevant changes in this file.

More information about the webkit-reviews mailing list