[webkit-reviews] review canceled: [Bug 227599] loadSimulatedRequest: should do same delegate callbacks as loadHTMLString and loadData : [Attachment 432841] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has canceled Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 227599: loadSimulatedRequest: should do same delegate callbacks as
loadHTMLString and loadData
https://bugs.webkit.org/show_bug.cgi?id=227599

Attachment 432841: Patch

https://bugs.webkit.org/attachment.cgi?id=432841&action=review




--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 432841
  --> https://bugs.webkit.org/attachment.cgi?id=432841
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432841&action=review

> Source/WebKit/ChangeLog:9
> +

I also wanted to add this:
Before this change we set SubstituteData.failingURL, which in
FrameLoader::PolicyChecker::checkNavigationPolicy makes it behave more like
_loadAlternateHTMLString which doesn't call decidePolicyForNavigationAction and
does add a back/forward entry.	We want it to behave more like loadHTMLString,
which does call decidePolicyForNavigationAction and doesn't add a back/forward
entry.	Except we do want it to add a back/forward entry.  This patch is to
accomplish that.