[webkit-reviews] review granted: [Bug 227526] [GTK] Pack header and .pc files in the built-product archive : [Attachment 432782] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 227526: [GTK] Pack header and .pc files in the built-product archive
https://bugs.webkit.org/show_bug.cgi?id=227526

Attachment 432782: Patch

https://bugs.webkit.org/attachment.cgi?id=432782&action=review




--- Comment #12 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 432782
  --> https://bugs.webkit.org/attachment.cgi?id=432782
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432782&action=review

Nice, this looks a lot better than the original version of this patch.

> Source/WebKit/gtk/webkit2gtk-web-extension.pc.in:5
> +revision=@SVN_REVISION@

I think I would land these revision=@SVN_REVISION@ changes in a separate
bug/patch since they're largely unrelated to the bulk of this patch. You can
set r=me.

P.S. I guess you know this will break as soon as we switch to GitHub. ;)